Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format Cj docs #10

Merged
merged 6 commits into from
Sep 19, 2023
Merged

Format Cj docs #10

merged 6 commits into from
Sep 19, 2023

Conversation

GabrielaReyna
Copy link
Contributor

  • Formatting of code blocks and code lines
  • Sorted headers depths
  • Sorted links (checked if they go where they should go and replaced full ugly URLs with associated text)

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 13, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 59e56da
Status: ✅  Deploy successful!
Preview URL: https://ead1f0ee.labs-leaningtech-com.pages.dev
Branch Preview URL: https://cj-docs.labs-leaningtech-com.pages.dev

View logs

@GabrielaReyna GabrielaReyna marked this pull request as ready for review September 14, 2023 11:50
Copy link
Contributor

@bates64 bates64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work! Vale is righly complaining about capitalisation in a few files, check the review page or run Vale locally to see the issues. For complaints that shouldn't be complaints (such as the "iText" one), add e.g. iText to https://github.com/leaningtech/labs.leaningtech.com/blob/main/.github/styles/Vocab/LeaningTechnologies/accept.txt. Good to merge after Vale's problems are resolved.

@GabrielaReyna
Copy link
Contributor Author

I have made corrections on spelling etc and added words to the accepted.txt list. I skipped some words that were started with uppercase since they were the first on a title.

@bates64 bates64 changed the title Cj docs Format Cj docs Sep 19, 2023
@bates64 bates64 merged commit 3022c9e into main Sep 19, 2023
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants